Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make xtask rfd new include title in RFD file #426

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

alilleybrinker
Copy link
Collaborator

Previously when making a new RFD, the xtask command would generate one without a YAML frontmatter, which would cause compilation with zola to fail. This fixes that, now including a YAML frontmatter with a title field filled with the title the user provided on the CLI.

Closes #425.

Previously when making a new RFD, the `xtask` command would generate
one without a YAML frontmatter, which would cause compilation with
`zola` to fail. This fixes that, now including a YAML frontmatter
with a `title` field filled with the title the user provided on
the CLI.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
@alilleybrinker alilleybrinker added type: enhancement New feature or request product: project Relates to the project itself labels Sep 19, 2024
@alilleybrinker alilleybrinker added this to the 3.7.0 milestone Sep 19, 2024
@alilleybrinker alilleybrinker requested a review from a team September 19, 2024 20:53
@alilleybrinker alilleybrinker self-assigned this Sep 19, 2024
@alilleybrinker alilleybrinker requested review from cstepanian and removed request for a team September 19, 2024 20:53
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@j-lanson j-lanson merged commit 52f6560 into main Sep 20, 2024
9 checks passed
@alilleybrinker alilleybrinker deleted the alilleybrinker/rfd-yaml branch September 20, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: project Relates to the project itself type: enhancement New feature or request
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Make cargo xtask rfd new generate the RFD .md file with a YAML frontmatter
2 participants